Skip to content

Gradle dependency resolution issues with parent POM #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
distributedlock opened this issue Apr 20, 2020 · 4 comments
Closed

Gradle dependency resolution issues with parent POM #30

distributedlock opened this issue Apr 20, 2020 · 4 comments
Assignees
@cgrushko @distributedlock

Comments

@distributedlock
Copy link
Contributor

distributedlock commented Apr 20, 2020 •
edited
Loading

No description provided.

@distributedlock distributedlock changed the title Gradle dependency resolution issues Gradle dependency resolution issues with parent POM Apr 20, 2020
@cgrushko
Copy link
Contributor

Exciting!!!
I'll try to look at it ASAP. Thanks for the report.

@cgrushko cgrushko self-assigned this Apr 20, 2020
@cgrushko
Copy link
Contributor

So, the 'parent' thing is due to us building ktfmt against a local checkout of google-java-format. It's done so we don't need to wait for GJF releases after we make changes to it that we need for ktfmt.
I'll see if we still need it, and whether it's actually a problem (GJF might be ok with releasing for us)

cc @cushon

This was referenced May 1, 2020
Closed
Closed
facebook-github-bot pushed a commit that referenced this issue May 4, 2020
@cgrushko @facebook-github-bot
Use google-java-format 1.8 from Maven Central (#31)
d5c5cab 
Summary:
instead of vendoring the source.

GJF 1.8 requires JDK 11+, so `ktfmt` will also now require JDK 11+.

This unlocks #30
Pull Request resolved: #31

Test Plan: GitHub's CI: #31

Reviewed By: strulovich

Differential Revision: D21368968

Pulled By: cgrushko

fbshipit-source-id: 91b0f0bfc0a905bda05041528187d54d2fe4a370
@cgrushko
Copy link
Contributor

cgrushko commented May 4, 2020

@ranadeeppolavarapu, can you give it another try? use the coordinates com.facebook:ktfmt:0.13.

@cgrushko
Copy link
Contributor

cgrushko commented May 4, 2020

Nice!!! I'll release 0.13 then.

@cgrushko cgrushko closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgrushko cgrushko

@distributedlock distributedlock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgrushko @distributedlock